Documentation: Order of messages #8326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pylint-dev#7162, "we decreed" that the `bad_code` goes first, then the `good_code`. Fixup current changes, to revert "back to standards". Additionally, tackle the comment here pylint-dev#8287 (comment) "Message emitted" is technically still code (`%-formatting`); let us make it stand out properly. Signed-off-by: Stavros Ntentos <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8326 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 177 177
Lines 18703 18703
=======================================
Hits 17855 17855
Misses 848 848 |
Pierre-Sassoulas
added
Documentation 📗
Skip news 🔇
Wrapping "Message emitted" in monospaced formatting, causes `W1507` (`pylint/checkers/stdlib.py`) to fail on a stray space. Fix that - as it seems to be the only outlier. (Might've been nice for a more formal check in the first place 🙏). Signed-off-by: Stavros Ntentos <[email protected]>
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit dd8d3da |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7162, "we decreed" that the
bad_codegoes first, then thegood_code.Fixup current changes, to revert "back to standards".
Additionally, tackle the comment here
#8287 (comment)
"Message emitted" is technically still code (
%-formatting); let us make it stand out properly.Type of Changes
Description
Refs #8287
Closes #8321